Bug 116235

Summary: Add stubs for ContextMenu and ContextMenuItem
Product: WebKit Reporter: Jesus Sanchez-Palencia <jesus>
Component: WebCore Misc.Assignee: Jesus Sanchez-Palencia <jesus>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, gyuyoung.kim, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 111874    
Attachments:
Description Flags
Patch
none
Patch none

Jesus Sanchez-Palencia
Reported 2013-05-16 11:10:17 PDT
Ports relying on ENABLE(CROSS_PLATFORM_CONTEXT_MENU) only need a stub implementation for their ContextMenu and ContextMenuItem. We should add defaults ContextMenuItemCommon.cpp and ContextMenuCommon.cpp to be shared between these ports, and remove the duplicated files.
Attachments
Patch (15.48 KB, patch)
2013-05-16 11:36 PDT, Jesus Sanchez-Palencia 		no flags
DetailsFormatted DiffDiff
Patch (15.49 KB, patch)
2013-05-16 12:36 PDT, Jesus Sanchez-Palencia 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jesus Sanchez-Palencia
Comment 1 2013-05-16 11:36:32 PDT
Created attachment 201976 [details] Patch
Antonio Gomes
Comment 2 2013-05-16 12:02:06 PDT
Comment on attachment 201976 [details] Patch Lets use the *None.cpp pattern to name these files.
Jesus Sanchez-Palencia
Comment 3 2013-05-16 12:36:00 PDT
Created attachment 201982 [details] Patch
WebKit Commit Bot
Comment 4 2013-05-16 20:28:23 PDT
Comment on attachment 201982 [details] Patch Clearing flags on attachment: 201982 Committed r150240: <http://trac.webkit.org/changeset/150240>
WebKit Commit Bot
Comment 5 2013-05-16 20:28:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.