Bug 116231

Summary: Enable the CSSVariables setting in css-variable-definition.html test
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: New BugsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, svillar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sergio Villar Senin
Reported 2013-05-16 09:07:44 PDT
Enable the CSSVariables setting in css-variable-definition.html test
Attachments
Patch (2.65 KB, patch)
2013-05-16 09:09 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2013-05-16 09:09:53 PDT
Created attachment 201964 [details] Patch
Martin Robinson
Comment 2 2013-05-16 09:12:17 PDT
Comment on attachment 201964 [details] Patch Doesn't this allow unskipping some tests?
Sergio Villar Senin
Comment 3 2013-05-16 09:15:45 PDT
(In reply to comment #2) > (From update of attachment 201964 [details]) > Doesn't this allow unskipping some tests? I don't get what you mean. The patch fixes the test. It was not failing because the only difference in the output (if the CSS variables stuff is not enabled) is the text color. So both the test and the ref test where showing the text without any color because the CSS variables setting was not enabled at runtime..
Andreas Kling
Comment 4 2013-05-16 09:54:17 PDT
Comment on attachment 201964 [details] Patch Oops! Funny bug :) r=me
Sergio Villar Senin
Comment 5 2013-05-16 10:06:32 PDT
Comment on attachment 201964 [details] Patch Clearing flags on attachment: 201964 Committed r150184: <http://trac.webkit.org/changeset/150184>
Sergio Villar Senin
Comment 6 2013-05-16 10:06:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.