Bug 116231 - Enable the CSSVariables setting in css-variable-definition.html test
Summary: Enable the CSSVariables setting in css-variable-definition.html test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-16 09:07 PDT by Sergio Villar Senin
Modified: 2013-05-16 10:06 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.65 KB, patch)
2013-05-16 09:09 PDT, Sergio Villar Senin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2013-05-16 09:07:44 PDT
Enable the CSSVariables setting in css-variable-definition.html test
Comment 1 Sergio Villar Senin 2013-05-16 09:09:53 PDT
Created attachment 201964 [details]
Patch
Comment 2 Martin Robinson 2013-05-16 09:12:17 PDT
Comment on attachment 201964 [details]
Patch

Doesn't this allow unskipping some tests?
Comment 3 Sergio Villar Senin 2013-05-16 09:15:45 PDT
(In reply to comment #2)
> (From update of attachment 201964 [details])
> Doesn't this allow unskipping some tests?

I don't get what you mean. The patch fixes the test. 

It was not failing because the only difference in the output (if the CSS variables stuff is not enabled) is the text color. So both the test and the ref test where showing the text without any color because the CSS variables setting was not enabled at runtime..
Comment 4 Andreas Kling 2013-05-16 09:54:17 PDT
Comment on attachment 201964 [details]
Patch

Oops! Funny bug :)
r=me
Comment 5 Sergio Villar Senin 2013-05-16 10:06:32 PDT
Comment on attachment 201964 [details]
Patch

Clearing flags on attachment: 201964

Committed r150184: <http://trac.webkit.org/changeset/150184>
Comment 6 Sergio Villar Senin 2013-05-16 10:06:38 PDT
All reviewed patches have been landed.  Closing bug.