Bug 116205

Summary: Use SetFilePointer instead of SetFilePointerEx in FileSystemWin
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: PlatformAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on: 115246    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
rniwa: review+
Patch for landing none

Description Patrick R. Gansterer 2013-05-15 21:49:52 PDT 
Use SetFilePointer instead of SetFilePointerEx in FileSystemWin
Comment 1 Patrick R. Gansterer 2013-05-15 21:59:42 PDT 
Created attachment 201920 [details]
Patch
Comment 2 Patrick R. Gansterer 2013-05-15 23:36:04 PDT 
Created attachment 201925 [details]
Patch
Comment 3 Ryosuke Niwa 2013-06-14 15:35:00 PDT 
Comment on attachment 201925 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201925&action=review

> Source/WebCore/platform/win/FileSystemWin.cpp:336
> +    if (largeOffset.LowPart == 0xFFFFFFFF && GetLastError() != NO_ERROR)

Can we compare LowPart to INVALID_SET_FILE_POINTER instead?
Comment 4 Patrick R. Gansterer 2013-06-24 06:20:09 PDT 
Created attachment 205290 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2013-06-24 07:17:12 PDT 
Comment on attachment 205290 [details]
Patch for landing

Clearing flags on attachment: 205290

Committed r151909: <http://trac.webkit.org/changeset/151909>
Comment 6 WebKit Commit Bot 2013-06-24 07:17:14 PDT 
All reviewed patches have been landed.  Closing bug.