Bug 116205

Summary: Use SetFilePointer instead of SetFilePointerEx in FileSystemWin
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: PlatformAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on: 115246    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
rniwa: review+
Patch for landing none

Patrick R. Gansterer
Reported 2013-05-15 21:49:52 PDT
Use SetFilePointer instead of SetFilePointerEx in FileSystemWin
Attachments
Patch (1.59 KB, patch)
2013-05-15 21:59 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (1.59 KB, patch)
2013-05-15 23:36 PDT, Patrick R. Gansterer 		rniwa: review+
DetailsFormatted DiffDiff
Patch for landing (1.60 KB, patch)
2013-06-24 06:20 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2013-05-15 21:59:42 PDT
Created attachment 201920 [details] Patch
Patrick R. Gansterer
Comment 2 2013-05-15 23:36:04 PDT
Created attachment 201925 [details] Patch
Ryosuke Niwa
Comment 3 2013-06-14 15:35:00 PDT
Comment on attachment 201925 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201925&action=review > Source/WebCore/platform/win/FileSystemWin.cpp:336 > + if (largeOffset.LowPart == 0xFFFFFFFF && GetLastError() != NO_ERROR) Can we compare LowPart to INVALID_SET_FILE_POINTER instead?
Patrick R. Gansterer
Comment 4 2013-06-24 06:20:09 PDT
Created attachment 205290 [details] Patch for landing
WebKit Commit Bot
Comment 5 2013-06-24 07:17:12 PDT
Comment on attachment 205290 [details] Patch for landing Clearing flags on attachment: 205290 Committed r151909: <http://trac.webkit.org/changeset/151909>
WebKit Commit Bot
Comment 6 2013-06-24 07:17:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.