Summary: | makeRGBAFromNSColor throws an exception if given a color in a greyscale colorspace | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
Component: | WebCore Misc. | Assignee: | Tim Horton <thorton> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bdakin, simon.fraser | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Tim Horton
2013-05-15 18:11:15 PDT
Created attachment 201904 [details]
patch
Comment on attachment 201904 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=201904&action=review > Source/WebCore/platform/graphics/mac/ColorMac.mm:63 > + return makeRGBA(0, 0, 0, 0); Not sure what a reasonable fallback color is. Comment on attachment 201904 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=201904&action=review > Source/WebCore/platform/graphics/mac/ColorMac.mm:61 > + Maybe remove this blank line. |