Bug 116198

Summary: makeRGBAFromNSColor throws an exception if given a color in a greyscale colorspace
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebCore Misc.Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch simon.fraser: review+

Tim Horton
Reported 2013-05-15 18:11:15 PDT
The comment in ColorMac.mm about NSColor things not throwing exceptions is a lie. <rdar://problem/13904395>
Attachments
patch (2.21 KB, patch)
2013-05-15 18:19 PDT, Tim Horton 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2013-05-15 18:19:45 PDT
Created attachment 201904 [details] patch
Tim Horton
Comment 2 2013-05-15 18:22:00 PDT
Comment on attachment 201904 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=201904&action=review > Source/WebCore/platform/graphics/mac/ColorMac.mm:63 > + return makeRGBA(0, 0, 0, 0); Not sure what a reasonable fallback color is.
Simon Fraser (smfr)
Comment 3 2013-05-15 18:30:24 PDT
Comment on attachment 201904 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=201904&action=review > Source/WebCore/platform/graphics/mac/ColorMac.mm:61 > + Maybe remove this blank line.
Tim Horton
Comment 4 2013-05-15 18:35:12 PDT
http://trac.webkit.org/changeset/150167
Note You need to log in before you can comment on or make changes to this bug.