Bug 116197

Summary: Stop using the factory pattern in FileIconLoaderClient
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ossy, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 116207    
Bug Blocks:    
Attachments:
Description Flags
Patch kling: review+

Anders Carlsson
Reported 2013-05-15 18:08:22 PDT
Stop using the factory pattern in FileIconLoaderClient
Attachments
Patch (4.56 KB, patch)
2013-05-15 18:09 PDT, Anders Carlsson 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-05-15 18:09:12 PDT
Created attachment 201903 [details] Patch
Anders Carlsson
Comment 2 2013-05-15 18:17:27 PDT
Committed r150165: <http://trac.webkit.org/changeset/150165>
Csaba Osztrogonác
Comment 3 2013-05-15 22:15:09 PDT
(In reply to comment #2) > Committed r150165: <http://trac.webkit.org/changeset/150165> It made zillion tests crash everywhere. Could you fix it? for example on Apple Mac bots: http://build.webkit.org/builders/Apple%20Lion%20Release%20WK1%20%28Tests%29/builds/12484
WebKit Commit Bot
Comment 4 2013-05-15 22:51:07 PDT
Re-opened since this is blocked by bug 116207
Simon Fraser (smfr)
Comment 5 2013-05-15 22:52:35 PDT
Pls run tests before committing.
Note You need to log in before you can comment on or make changes to this bug.