Summary: | Stop using the factory pattern in FileIconLoaderClient | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, ossy, simon.fraser | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 116207 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Anders Carlsson
2013-05-15 18:08:22 PDT
Created attachment 201903 [details]
Patch
Committed r150165: <http://trac.webkit.org/changeset/150165> (In reply to comment #2) > Committed r150165: <http://trac.webkit.org/changeset/150165> It made zillion tests crash everywhere. Could you fix it? for example on Apple Mac bots: http://build.webkit.org/builders/Apple%20Lion%20Release%20WK1%20%28Tests%29/builds/12484 Re-opened since this is blocked by bug 116207 Pls run tests before committing. |