Bug 116197 - Stop using the factory pattern in FileIconLoaderClient
Summary: Stop using the factory pattern in FileIconLoaderClient
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
Depends on: 116207
  Show dependency treegraph
Reported: 2013-05-15 18:08 PDT by Anders Carlsson
Modified: 2013-05-16 07:46 PDT (History)
3 users (show)

See Also:

Patch (4.56 KB, patch)
2013-05-15 18:09 PDT, Anders Carlsson
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-05-15 18:08:22 PDT
Stop using the factory pattern in FileIconLoaderClient
Comment 1 Anders Carlsson 2013-05-15 18:09:12 PDT
Created attachment 201903 [details]
Comment 2 Anders Carlsson 2013-05-15 18:17:27 PDT
Committed r150165: <http://trac.webkit.org/changeset/150165>
Comment 3 Csaba Osztrogonác 2013-05-15 22:15:09 PDT
(In reply to comment #2)
> Committed r150165: <http://trac.webkit.org/changeset/150165>

It made zillion tests crash everywhere. Could you fix it?
for example on Apple Mac bots: http://build.webkit.org/builders/Apple%20Lion%20Release%20WK1%20%28Tests%29/builds/12484
Comment 4 WebKit Commit Bot 2013-05-15 22:51:07 PDT
Re-opened since this is blocked by bug 116207
Comment 5 Simon Fraser (smfr) 2013-05-15 22:52:35 PDT
Pls run tests before committing.