Bug 116180

Summary: [Mac] media engine may deliver NULL in-band "cue"
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch none

Eric Carlson
Reported 2013-05-15 12:46:35 PDT
r145326 add a NULL check to InbandTextTrackPrivateAVF::processCue, but the debug-only logging added in r149187 is before the NULL check so it will crash when a NULL "cue" is delivered by the media engine.
Attachments
Proposed patch (1.54 KB, patch)
2013-05-15 12:54 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-05-15 12:48:39 PDT
<rdar://problem/13902910>
Eric Carlson
Comment 2 2013-05-15 12:54:27 PDT
Created attachment 201870 [details] Proposed patch
Jer Noble
Comment 3 2013-05-15 12:56:17 PDT
Comment on attachment 201870 [details] Proposed patch Yay null checks!
WebKit Commit Bot
Comment 4 2013-05-15 15:38:21 PDT
Comment on attachment 201870 [details] Proposed patch Clearing flags on attachment: 201870 Committed r150153: <http://trac.webkit.org/changeset/150153>
WebKit Commit Bot
Comment 5 2013-05-15 15:38:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.