Bug 116179

Summary: [Mac] Make Clipboard::create functions for Mac platform independent by moving Pasteboard creation to Pasteboard functions
Product: WebKit Reporter: Darin Adler <darin>
Component: PlatformAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, esprehn+autocc, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Bug Depends on:    
Bug Blocks: 115980    
Attachments:
Description Flags
Patch
kling: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 none

Darin Adler
Reported 2013-05-15 12:45:20 PDT
[Mac] Make Clipboard::create functions for Mac platform independent by moving Pasteboard creation to Pasteboard functions
Attachments
Patch (7.31 KB, patch)
2013-05-15 12:47 PDT, Darin Adler 		kling: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (622.90 KB, application/zip)
2013-05-15 13:35 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2013-05-15 12:47:36 PDT
Created attachment 201868 [details] Patch
Andreas Kling
Comment 2 2013-05-15 13:07:05 PDT
Comment on attachment 201868 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201868&action=review r=me > Source/WebCore/platform/Pasteboard.h:99 > + static PassOwnPtr<Pasteboard> createPrivate(); // Corresponds to the "unique pasteboard" concept on Mac. Used in editing, not sure exactly for what purpose. Lovely comment!
Build Bot
Comment 3 2013-05-15 13:35:10 PDT
Comment on attachment 201868 [details] Patch Attachment 201868 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/478562 New failing tests: editing/pasteboard/get-data-text-plain-paste.html
Build Bot
Comment 4 2013-05-15 13:35:11 PDT
Created attachment 201875 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2
Darin Adler
Comment 5 2013-05-15 21:38:32 PDT
Checking on the test failure before landing this.
Darin Adler
Comment 6 2013-05-16 08:43:34 PDT
Committed r150183: <http://trac.webkit.org/changeset/150183>
Note You need to log in before you can comment on or make changes to this bug.