Bug 116179 - [Mac] Make Clipboard::create functions for Mac platform independent by moving Pasteboard creation to Pasteboard functions
Summary: [Mac] Make Clipboard::create functions for Mac platform independent by moving...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks: 115980
  Show dependency tree / graph
 
Reported: 2013-05-15 12:45 PDT by Darin Adler
Modified: 2013-05-16 08:43 PDT (History)
4 users (show)

See Also:

Attachments
Patch (7.31 KB, patch)
2013-05-15 12:47 PDT, Darin Adler 		kling: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (622.90 KB, application/zip)
2013-05-15 13:35 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2013-05-15 12:45:20 PDT 
[Mac] Make Clipboard::create functions for Mac platform independent by moving Pasteboard creation to Pasteboard functions
Comment 1 Darin Adler 2013-05-15 12:47:36 PDT 
Created attachment 201868 [details]
Patch
Comment 2 Andreas Kling 2013-05-15 13:07:05 PDT 
Comment on attachment 201868 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201868&action=review

r=me

> Source/WebCore/platform/Pasteboard.h:99
> +    static PassOwnPtr<Pasteboard> createPrivate(); // Corresponds to the "unique pasteboard" concept on Mac. Used in editing, not sure exactly for what purpose.

Lovely comment!
Comment 3 Build Bot 2013-05-15 13:35:10 PDT 
Comment on attachment 201868 [details]
Patch

Attachment 201868 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/478562

New failing tests:
editing/pasteboard/get-data-text-plain-paste.html
Comment 4 Build Bot 2013-05-15 13:35:11 PDT 
Created attachment 201875 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2
Comment 5 Darin Adler 2013-05-15 21:38:32 PDT 
Checking on the test failure before landing this.
Comment 6 Darin Adler 2013-05-16 08:43:34 PDT 
Committed r150183: <http://trac.webkit.org/changeset/150183>