Bug 116172

Summary: Avoid backing store for the WebFrameView's layer when the WebView is layer-backed
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 116214    
Bug Blocks:    
Attachments:
Description Flags
Patch thorton: review+

Simon Fraser (smfr)
Reported 2013-05-15 11:24:45 PDT
Avoid backing store for the WebFrameView's layer when the WebView is layer-backed
Attachments
Patch (2.62 KB, patch)
2013-05-15 11:29 PDT, Simon Fraser (smfr) 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2013-05-15 11:29:01 PDT
Created attachment 201859 [details] Patch
Simon Fraser (smfr)
Comment 2 2013-05-15 11:29:52 PDT
*** Bug 116171 has been marked as a duplicate of this bug. ***
Simon Fraser (smfr)
Comment 3 2013-05-15 11:30:48 PDT
<rdar://problem/13741243>
Tim Horton
Comment 4 2013-05-15 11:33:24 PDT
Comment on attachment 201859 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201859&action=review > Source/WebKit/mac/WebView/WebFrameView.mm:82 > +@interface NSView (AppKitSecretsIKnow) (Details) > Source/WebKit/mac/WebView/WebFrameView.mm:490 > + if ([self documentView] == nil) { "comparison with nil/0/etc" la la la stylebot
Simon Fraser (smfr)
Comment 5 2013-05-15 19:05:05 PDT
r150168
WebKit Commit Bot
Comment 6 2013-05-16 02:59:59 PDT
Re-opened since this is blocked by bug 116214
Tim Horton
Comment 7 2013-05-16 03:00:22 PDT
-[WebFrameView setBackgroundColor:]: unrecognized selector sent to instance 0x7f9cc5d64c50
Simon Fraser (smfr)
Comment 8 2013-05-16 09:00:40 PDT
Boo.
Simon Fraser (smfr)
Comment 9 2013-05-16 11:32:46 PDT
That only happened with the 1Password extension installed, which is why I didn't see it.
Simon Fraser (smfr)
Comment 10 2013-05-16 11:40:08 PDT
Re-landed in https://trac.webkit.org/r150194
Note You need to log in before you can comment on or make changes to this bug.