Bug 116166

Summary: [Mac] Make Clipboard class no longer polymorphic by removing the last virtual functions
Product: WebKit Reporter: Darin Adler <darin>
Component: PlatformAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Bug Depends on:    
Bug Blocks: 115980    
Attachments:
Description Flags
Patch andersca: review+

Darin Adler
Reported 2013-05-15 10:25:14 PDT
[Mac] Make Clipboard class no longer polymorphic by removing the last virtual functions
Attachments
Patch (2.45 KB, patch)
2013-05-15 10:29 PDT, Darin Adler 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2013-05-15 10:29:04 PDT
Created attachment 201854 [details] Patch
Alexey Proskuryakov
Comment 2 2013-05-15 11:44:56 PDT
Comment on attachment 201854 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201854&action=review Does the improvement from making a few functions non-virtual outweigh the confusion from them being different across ports? > Source/WebCore/dom/Clipboard.h:72 > - virtual ~Clipboard(); > + LEGACY_VIRTUAL ~Clipboard(); I'm not sure that LEGACY_VIRTUAL is a great name, I certainly wouldn't understand it if I saw it.
Alexey Proskuryakov
Comment 3 2013-05-15 11:45:10 PDT
(I also said r+ with my comment).
Darin Adler
Comment 4 2013-05-15 12:37:23 PDT
Committed r150138: <http://trac.webkit.org/changeset/150138>
Note You need to log in before you can comment on or make changes to this bug.