Summary: | [Mac] Make Clipboard class no longer polymorphic by removing the last virtual functions | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
Component: | Platform | Assignee: | Darin Adler <darin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 115980 | ||||||
Attachments: |
|
Description
Darin Adler
2013-05-15 10:25:14 PDT
Created attachment 201854 [details]
Patch
Comment on attachment 201854 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201854&action=review Does the improvement from making a few functions non-virtual outweigh the confusion from them being different across ports? > Source/WebCore/dom/Clipboard.h:72 > - virtual ~Clipboard(); > + LEGACY_VIRTUAL ~Clipboard(); I'm not sure that LEGACY_VIRTUAL is a great name, I certainly wouldn't understand it if I saw it. (I also said r+ with my comment). Committed r150138: <http://trac.webkit.org/changeset/150138> |