Bug 116160

Summary: [CSS Shapes] LineSegment logicalLeft and logicalRight members should be floats
Product: WebKit Reporter: Hans Muller <giles_joplin>
Component: CSSAssignee: Hans Muller <giles_joplin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 98664    
Attachments:
Description Flags
Patch none

Hans Muller
Reported 2013-05-15 09:35:37 PDT
The type of LineSegment logicalLeft and logicalRight edges should not have been changed to LayoutUnit. They should be floats because all of the RenderBlockLineLayout calculations are based on floats for left,right values (vertical values are LayoutUnits). The mistake was pointed out and corrected in Blink, here: https://chromiumcodereview.appspot.com/14892005#msg6
Attachments
Patch (1.19 KB, patch)
2014-04-03 10:47 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2014-04-03 10:47:48 PDT
Created attachment 228519 [details] Patch
Andreas Kling
Comment 2 2014-04-03 15:03:43 PDT
Comment on attachment 228519 [details] Patch rs=me
WebKit Commit Bot
Comment 3 2014-04-03 15:35:01 PDT
Comment on attachment 228519 [details] Patch Clearing flags on attachment: 228519 Committed r166747: <http://trac.webkit.org/changeset/166747>
WebKit Commit Bot
Comment 4 2014-04-03 15:35:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.