Bug 116160 - [CSS Shapes] LineSegment logicalLeft and logicalRight members should be floats
Summary: [CSS Shapes] LineSegment logicalLeft and logicalRight members should be floats
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Muller
URL:
Keywords:
Depends on:
Blocks: 98664
  Show dependency treegraph
 
Reported: 2013-05-15 09:35 PDT by Hans Muller
Modified: 2014-04-03 15:35 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.19 KB, patch)
2014-04-03 10:47 PDT, Zoltan Horvath
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Muller 2013-05-15 09:35:37 PDT
The type of LineSegment logicalLeft and logicalRight edges should not have been changed to LayoutUnit.

They should be floats because all of the RenderBlockLineLayout calculations are based on floats for left,right values (vertical values are LayoutUnits).

The mistake was pointed out and corrected in Blink, here: https://chromiumcodereview.appspot.com/14892005#msg6
Comment 1 Zoltan Horvath 2014-04-03 10:47:48 PDT
Created attachment 228519 [details]
Patch
Comment 2 Andreas Kling 2014-04-03 15:03:43 PDT
Comment on attachment 228519 [details]
Patch

rs=me
Comment 3 WebKit Commit Bot 2014-04-03 15:35:01 PDT
Comment on attachment 228519 [details]
Patch

Clearing flags on attachment: 228519

Committed r166747: <http://trac.webkit.org/changeset/166747>
Comment 4 WebKit Commit Bot 2014-04-03 15:35:04 PDT
All reviewed patches have been landed.  Closing bug.