| Summary: | [GTK] WebAudio doesn't build in WebKitGTK+ 2.0.2 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alberto Garcia <berto> | ||||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cgarcia, gustavo, mrobinson, zan | ||||||
| Priority: | P3 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Attachments: |
|
||||||||
Unfortunate. Will you be able to provide the patch? Created attachment 201835 [details]
Patch
Created attachment 201836 [details]
Patch
I'm a bit confused. You say this was fixed in master for https://bugs.webkit.org/show_bug.cgi?id=113349, but https://bugs.webkit.org/show_bug.cgi?id=113349 was merged into 2.0.1. (In reply to comment #4) > I'm a bit confused. You say this was fixed in master for > https://bugs.webkit.org/show_bug.cgi?id=113349, but > https://bugs.webkit.org/show_bug.cgi?id=113349 was merged into > 2.0.1. I've just checked the commit in 2.0.1, it kept the ENABLE_WEB_AUDIO=0 line intact. See line 174 of http://trac.webkit.org/changeset/148428/releases/WebKitGTK/webkit-2.0/Source/autotools/SetupWebKitFeatures.m4 Compare it with the commit in master: http://trac.webkit.org/changeset/147967/trunk/Source/autotools/SetupWebKitFeatures.m4 You can see the problem easily by running configure --enable-web-audio and checking the value of ENABLE_WEB_AUDIO in WebKitFeatures.h I took the liberty of landing this to the stable branch: http://trac.webkit.org/changeset/150185 (In reply to comment #7) > I took the liberty of landing this to the stable branch: Great, thanks I think bug 115612 and bug 116227 are also worthwhile. I believe with these all three we can make a full parallel build with all features enabled. |
I get .libs/libwebkitgtk-3.0.so: undefined reference to `WebCore::VectorMath::vsmul(float const*, int, float const*, float*, int, unsigned long)' The problem is that the value of ENABLE_WEB_AUDIO from configure is overriden in Source/autotools/SetupWebKitFeatures.m4 diff --git a/Source/autotools/SetupWebKitFeatures.m4 b/Source/autotools/SetupWebKitFeatures.m4 index 5d59b6e..a2a7c45 100644 --- a/Source/autotools/SetupWebKitFeatures.m4 +++ b/Source/autotools/SetupWebKitFeatures.m4 @@ -171,7 +171,6 @@ $srcdir/Tools/gtk/generate-feature-defines-files $CONFIGURABLE_FEATURE_DEFINES \ ENABLE_USER_TIMING=0 \ ENABLE_VIBRATION=0 \ ENABLE_VIDEO_TRACK=0 \ - ENABLE_WEB_AUDIO=0 \ ENABLE_WEB_SOCKETS=1 \ ENABLE_WEB_TIMING=1 \ ENABLE_WORKERS=1 \ This was fixed indirectly in master for bug 113349.