Bug 116143

Summary: [sh4] savedTimeoutReg should be removed from JITStackFrame
Product: WebKit Reporter: Julien Brianceau <jbriance>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ggaren, mark.lam, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Remove savedTimeoutReg from JITStackFrame for sh4 base JIT none

Description Julien Brianceau 2013-05-15 03:09:01 PDT 
Since r148119, timeoutCheckRegister is removed from baseline JIT.

So we don't need to keep r8 register in JITStackFrame anymore for sh4 baseline JIT (see http://trac.webkit.org/changeset/148119/trunk/Source/JavaScriptCore/jit/JSInterfaceJIT.h).
Comment 1 Julien Brianceau 2013-05-15 03:17:50 PDT 
Created attachment 201811 [details]
Remove savedTimeoutReg from JITStackFrame for sh4 base JIT

I've tested this patch on r150106 and I didn't see regressions when running
- Tools/Scripts/run-javascriptcore-tests
- Tools/Scripts/run-fast-jsc
- SunSpider 1.0
Comment 2 Mark Lam 2013-05-15 08:25:52 PDT 
Comment on attachment 201811 [details]
Remove savedTimeoutReg from JITStackFrame for sh4 base JIT

LGTM but need someone else to r+.
Comment 3 Geoffrey Garen 2013-05-15 12:33:49 PDT 
Comment on attachment 201811 [details]
Remove savedTimeoutReg from JITStackFrame for sh4 base JIT

r=me
Comment 4 WebKit Commit Bot 2013-05-15 14:16:52 PDT 
Comment on attachment 201811 [details]
Remove savedTimeoutReg from JITStackFrame for sh4 base JIT

Clearing flags on attachment: 201811

Committed r150146: <http://trac.webkit.org/changeset/150146>
Comment 5 WebKit Commit Bot 2013-05-15 14:16:54 PDT 
All reviewed patches have been landed.  Closing bug.