Bug 116143 - [sh4] savedTimeoutReg should be removed from JITStackFrame
Summary: [sh4] savedTimeoutReg should be removed from JITStackFrame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-15 03:09 PDT by Julien Brianceau
Modified: 2013-05-15 14:16 PDT (History)
5 users (show)

See Also:

Attachments
Remove savedTimeoutReg from JITStackFrame for sh4 base JIT (2.36 KB, patch)
2013-05-15 03:17 PDT, Julien Brianceau 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2013-05-15 03:09:01 PDT 
Since r148119, timeoutCheckRegister is removed from baseline JIT.

So we don't need to keep r8 register in JITStackFrame anymore for sh4 baseline JIT (see http://trac.webkit.org/changeset/148119/trunk/Source/JavaScriptCore/jit/JSInterfaceJIT.h).
Comment 1 Julien Brianceau 2013-05-15 03:17:50 PDT 
Created attachment 201811 [details]
Remove savedTimeoutReg from JITStackFrame for sh4 base JIT

I've tested this patch on r150106 and I didn't see regressions when running
- Tools/Scripts/run-javascriptcore-tests
- Tools/Scripts/run-fast-jsc
- SunSpider 1.0
Comment 2 Mark Lam 2013-05-15 08:25:52 PDT 
Comment on attachment 201811 [details]
Remove savedTimeoutReg from JITStackFrame for sh4 base JIT

LGTM but need someone else to r+.
Comment 3 Geoffrey Garen 2013-05-15 12:33:49 PDT 
Comment on attachment 201811 [details]
Remove savedTimeoutReg from JITStackFrame for sh4 base JIT

r=me
Comment 4 WebKit Commit Bot 2013-05-15 14:16:52 PDT 
Comment on attachment 201811 [details]
Remove savedTimeoutReg from JITStackFrame for sh4 base JIT

Clearing flags on attachment: 201811

Committed r150146: <http://trac.webkit.org/changeset/150146>
Comment 5 WebKit Commit Bot 2013-05-15 14:16:54 PDT 
All reviewed patches have been landed.  Closing bug.