Bug 116121

Summary:

[Mac] Add tests for secure event input

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

116122

Bug Blocks:

Attachments:

Description	Flags
proposed patch	mrowe: review+

Description Alexey Proskuryakov 2013-05-14 12:56:19 PDT

We should have tests verifying that secure event input state (as set in password input fields) is enabled and disabled correctly. Historically, this was something that broke easily.

Comment 1 Alexey Proskuryakov 2013-05-14 13:55:24 PDT

Created attachment 201756 [details]
proposed patch

Comment 2 Mark Rowe (bdash) 2013-05-14 14:29:54 PDT

Comment on attachment 201756 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201756&action=review

> Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:222
> +		E1BA671D1742DA5A00C20251 /* Carbon.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = Carbon.framework; path = ../../../../../../System/Library/Frameworks/Carbon.framework; sourceTree = "<group>"; };

This path isn't right. I think you need to mark it as relative to the SDK.

Comment 3 Alexey Proskuryakov 2013-05-14 15:20:36 PDT

Committed <http://trac.webkit.org/r150090>.

Comment 4 Brent Fulgham 2013-05-14 18:21:29 PDT

Committed <https://trac.webkit.org/r150096> to fix non-Mac builds.

Comment 5 Ryosuke Niwa 2013-05-16 12:01:20 PDT

Corrected the erroneous merge on platform/mac/TestExpectations in http://trac.webkit.org/changeset/150195.