Bug 116117
Summary: | Flexbox preferred logical width computation algorithm incorrectly ignores flex-basis | ||
---|---|---|---|
Product: | WebKit | Reporter: | Dave Hyatt <hyatt> |
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW | ||
Severity: | Normal | CC: | ahmad.saleem792, cbiesinger, rreno, sgill26, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar, WPTImpact |
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=244051 |
Dave Hyatt
The preferred logical widths algorithm for flexbox needs to take flex-basis into account. Note it can't do that, though, until the spec changes to make 0 not be the default or content will break.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Ryan Reno
The algorithm has changed since this bug was created. See:
https://crbug.com/240765
https://github.com/w3c/csswg-drafts/issues/7189
I haven't read the spec closely yet nor that issue thread but I suspect this bug will be resolved by implementing the new spec text for the main axis width algorithm.
Radar WebKit Bug Importer
<rdar://problem/98793922>
Ryan Reno
WPT failures:
https://wpt.fyi/results/css/css-flexbox/intrinsic-size?label=experimental&label=master&aligned
We're only passing 2 of these tests.
Also need to do a WPT sync as there are more tests than we have in tree.
Ryan Reno
WPT sync landed in https://commits.webkit.org/253547@main
So now there's a target to hit.