Bug 116100

Summary: Media element shadow tree should reset style inheritance
Product: WebKit Reporter: Antoine Quint <graouts>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: UNCONFIRMED ---    
Severity: Normal CC: buildbot, commit-queue, dino, eric.carlson, esprehn+autocc, glenn, graouts, jer.noble, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
none
Patch
eric.carlson: review-, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 none

Description Antoine Quint 2013-05-14 05:19:00 PDT
In order for styles coming from the page to not affect the content displayed in a media element's shadow root, we need to reset style inheritance. This way only styles defined by the injected user-agent stylesheets will affect the rendering of the shadow content, such as media controls.
Comment 1 Radar WebKit Bug Importer 2013-05-14 05:19:16 PDT
<rdar://problem/13886140>
Comment 2 Antoine Quint 2013-05-14 05:21:53 PDT
Created attachment 201700 [details]
Patch
Comment 3 Build Bot 2013-05-14 07:06:37 PDT
Comment on attachment 201700 [details]
Patch

Attachment 201700 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/466591

New failing tests:
media/controls-styling-strict.html
media/video-controls-zoomed.html
Comment 4 Build Bot 2013-05-14 07:06:39 PDT
Created attachment 201711 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2
Comment 5 Antoine Quint 2013-05-14 07:26:19 PDT
The test at media/controls-styling-strict.html fails without this patch as well on my platform. However, media/video-controls-zoomed.html looks like a new failure indeed.
Comment 6 Antoine Quint 2013-05-14 07:36:28 PDT
Created attachment 201712 [details]
Patch
Comment 7 Ryosuke Niwa 2013-05-14 08:15:58 PDT
Comment on attachment 201712 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201712&action=review

> Source/WebCore/ChangeLog:10
> +

Can we add a test for this?
Comment 8 Build Bot 2013-05-14 08:58:52 PDT
Comment on attachment 201712 [details]
Patch

Attachment 201712 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/472224

New failing tests:
media/controls-styling-strict.html
Comment 9 Build Bot 2013-05-14 08:58:54 PDT
Created attachment 201721 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2
Comment 10 Eric Carlson 2013-05-14 10:13:55 PDT
Comment on attachment 201712 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201712&action=review

> Source/WebCore/ChangeLog:9
> +        the rendering of snapshotted plug-ins' shadow content.

"snapshotted plug-ins' shadow content"?

 :-)
Comment 11 Eric Carlson 2013-05-14 10:26:34 PDT
Comment on attachment 201712 [details]
Patch

Page styles are allowed to affect caption rendering. Can you set inheritance on the portion of the shadow DOM with controls only?
Comment 12 Eric Carlson 2013-08-09 14:31:07 PDT
*** Bug 119637 has been marked as a duplicate of this bug. ***