Summary: | Snapshotted plug-ins shadow tree should reset style inheritance | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||
Component: | Plug-ins | Assignee: | Antoine Quint <graouts> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dino, esprehn+autocc, graouts, jonlee, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Antoine Quint
2013-05-14 04:06:22 PDT
Created attachment 201696 [details]
Patch
Comment on attachment 201696 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201696&action=review > Source/WebCore/html/HTMLPlugInImageElement.cpp:370 > + root->setResetStyleInheritance(true); This needs a why comment. It’s not at all clear why this is here or what would break if we removed this, and there’s no regression test to help make it clear. (In reply to comment #3) > (From update of attachment 201696 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=201696&action=review > > > Source/WebCore/html/HTMLPlugInImageElement.cpp:370 > > + root->setResetStyleInheritance(true); > > This needs a why comment. It’s not at all clear why this is here or what would break if we removed this, and there’s no regression test to help make it clear. Adding a comment in the commit. Created attachment 201727 [details]
Patch for landing
Comment on attachment 201727 [details] Patch for landing Clearing flags on attachment: 201727 Committed r150081: <http://trac.webkit.org/changeset/150081> All reviewed patches have been landed. Closing bug. |