Bug 116068

Summary: No platform ever overrides RenderTheme::supportsCalendarPicker
Product: WebKit Reporter: Daker Fernandes Pinheiro <daker.pinheiro>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jesus, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Remove RenderTheme::supportsCalendarPicker
none
Remove RenderTheme::supportsCalendarPicker none

Daker Fernandes Pinheiro
Reported 2013-05-13 16:09:25 PDT
The method RenderTheme::supportsCalendarPicker always return false because no one ever overrides it.
Attachments
Remove RenderTheme::supportsCalendarPicker (5.31 KB, patch)
2013-05-13 16:11 PDT, Daker Fernandes Pinheiro 		no flags
DetailsFormatted DiffDiff
Remove RenderTheme::supportsCalendarPicker (4.57 KB, patch)
2013-05-13 16:13 PDT, Daker Fernandes Pinheiro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daker Fernandes Pinheiro
Comment 1 2013-05-13 16:11:00 PDT
Created attachment 201644 [details] Remove RenderTheme::supportsCalendarPicker
Daker Fernandes Pinheiro
Comment 2 2013-05-13 16:13:08 PDT
Created attachment 201645 [details] Remove RenderTheme::supportsCalendarPicker
Benjamin Poulain
Comment 3 2013-05-13 20:29:44 PDT
Comment on attachment 201645 [details] Remove RenderTheme::supportsCalendarPicker Good catch, it looks like this was a chromium feature without flags.
Jesus Sanchez-Palencia
Comment 4 2013-05-14 06:47:59 PDT
Comment on attachment 201645 [details] Remove RenderTheme::supportsCalendarPicker great!
WebKit Commit Bot
Comment 5 2013-05-14 07:29:24 PDT
Comment on attachment 201645 [details] Remove RenderTheme::supportsCalendarPicker Clearing flags on attachment: 201645 Committed r150069: <http://trac.webkit.org/changeset/150069>
WebKit Commit Bot
Comment 6 2013-05-14 07:29:25 PDT
All reviewed patches have been landed. Closing bug.
Kent Tamura
Comment 7 2013-05-14 14:02:36 PDT
(In reply to comment #5) > Committed r150069: <http://trac.webkit.org/changeset/150069> This removed INPUT_MULTIPLE_FIELDS_UI (inline-editing date/time types) + popup calendar picker configuration like Chromium. Have you confirmed any WebKit ports has no plan to use this configuration? If this change is ok for any ports, you can remove ENABLE_CALENDAR_PICKER code (+ Source/WebCore/Resources/pagepopups/calendarPicker.*) entirely now, and you need to update http://trac.webkit.org/wiki/EnableFormFeatures .
Daker Fernandes Pinheiro
Comment 8 2013-05-15 06:01:41 PDT
That's why I opened the bug. To discuss if someone does need it.
Note You need to log in before you can comment on or make changes to this bug.