| Summary: | No platform ever overrides RenderTheme::supportsCalendarPicker | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daker Fernandes Pinheiro <daker.pinheiro> | ||||||
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, jesus, tkent | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Daker Fernandes Pinheiro
2013-05-13 16:09:25 PDT
Created attachment 201644 [details]
Remove RenderTheme::supportsCalendarPicker
Created attachment 201645 [details]
Remove RenderTheme::supportsCalendarPicker
Comment on attachment 201645 [details]
Remove RenderTheme::supportsCalendarPicker
Good catch, it looks like this was a chromium feature without flags.
Comment on attachment 201645 [details]
Remove RenderTheme::supportsCalendarPicker
great!
Comment on attachment 201645 [details] Remove RenderTheme::supportsCalendarPicker Clearing flags on attachment: 201645 Committed r150069: <http://trac.webkit.org/changeset/150069> All reviewed patches have been landed. Closing bug. (In reply to comment #5) > Committed r150069: <http://trac.webkit.org/changeset/150069> This removed INPUT_MULTIPLE_FIELDS_UI (inline-editing date/time types) + popup calendar picker configuration like Chromium. Have you confirmed any WebKit ports has no plan to use this configuration? If this change is ok for any ports, you can remove ENABLE_CALENDAR_PICKER code (+ Source/WebCore/Resources/pagepopups/calendarPicker.*) entirely now, and you need to update http://trac.webkit.org/wiki/EnableFormFeatures . That's why I opened the bug. To discuss if someone does need it. |