Bug 116060

Summary: fourthTier: DFG should separate link phase into things that must be done concurrently and things that must be done synchronously, and have a way of passing data from one to the other
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 112839    
Attachments:
Description Flags
work in progress
none
work in progress
none
the patch
none
the patch barraclough: review+

Description Filip Pizlo 2013-05-13 14:15:43 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2013-05-13 14:18:03 PDT 
Created attachment 201633 [details]
work in progress
Comment 2 Filip Pizlo 2013-05-14 15:29:38 PDT 
Created attachment 201765 [details]
work in progress

It seems like it's starting to work.
Comment 3 Filip Pizlo 2013-05-14 16:49:44 PDT 
Created attachment 201771 [details]
the patch
Comment 4 Filip Pizlo 2013-05-15 10:22:40 PDT 
Created attachment 201853 [details]
the patch

Disassembly-related fixes.
Comment 5 Gavin Barraclough 2013-05-15 11:11:11 PDT 
Comment on attachment 201853 [details]
the patch

I buy that Plan can be a struct for now.  I expect that over time we'll want this to be a class, but we'll see. :-)
Might be worth considering making some of the immutable data members const.
Comment 6 Filip Pizlo 2013-05-15 12:33:20 PDT 
(In reply to comment #5)
> (From update of attachment 201853 [details])
> I buy that Plan can be a struct for now.  I expect that over time we'll want this to be a class, but we'll see. :-)
> Might be worth considering making some of the immutable data members const.

Yup, I've made some of the things const!
Comment 7 Filip Pizlo 2013-05-15 12:38:37 PDT 
Landed in http://trac.webkit.org/changeset/150139