Bug 116037

Summary:

Frame::editor() should return a reference

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eflews.bot, gtk-ews, gyuyoung.kim, philn, webkit-ews, xan.lopez

Priority:

P2

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Anders Carlsson

Reported 2013-05-13 08:49:43 PDT

Frame::editor() should return a reference

Attachments
Patch (250.59 KB, patch) 2013-05-13 08:56 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (250.93 KB, patch) 2013-05-15 07:17 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (256.56 KB, patch) 2013-05-15 07:44 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (263.73 KB, patch) 2013-05-15 08:17 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (275.43 KB, patch) 2013-05-15 08:30 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (277.84 KB, patch) 2013-05-15 09:20 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (281.36 KB, patch) 2013-05-15 10:16 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (281.66 KB, patch) 2013-05-15 12:39 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Anders Carlsson

Comment 1 2013-05-13 08:56:34 PDT

Created attachment 201571 [details] Patch

Darin Adler

Comment 2 2013-05-13 18:23:55 PDT

Comment on attachment 201571 [details] Patch Seems fine. Don’t break everything.

Anders Carlsson

Comment 3 2013-05-15 07:17:31 PDT

Created attachment 201824 [details] Patch

Early Warning System Bot

Comment 4 2013-05-15 07:25:42 PDT

Comment on attachment 201824 [details] Patch Attachment 201824 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/468872

Early Warning System Bot

Comment 5 2013-05-15 07:25:49 PDT

Comment on attachment 201824 [details] Patch Attachment 201824 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/479418

EFL EWS Bot

Comment 6 2013-05-15 07:28:29 PDT

Comment on attachment 201824 [details] Patch Attachment 201824 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/479422

EFL EWS Bot

Comment 7 2013-05-15 07:30:39 PDT

Comment on attachment 201824 [details] Patch Attachment 201824 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/472586

kov's GTK+ EWS bot

Comment 8 2013-05-15 07:33:47 PDT

Comment on attachment 201824 [details] Patch Attachment 201824 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/481054

Build Bot

Comment 9 2013-05-15 07:42:28 PDT

Comment on attachment 201824 [details] Patch Attachment 201824 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/472589

Anders Carlsson

Comment 10 2013-05-15 07:44:18 PDT

Created attachment 201830 [details] Patch

Early Warning System Bot

Comment 11 2013-05-15 07:51:52 PDT

Comment on attachment 201830 [details] Patch Attachment 201830 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/474522

Early Warning System Bot

Comment 12 2013-05-15 07:52:11 PDT

Comment on attachment 201830 [details] Patch Attachment 201830 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/470550

EFL EWS Bot

Comment 13 2013-05-15 07:58:40 PDT

Comment on attachment 201830 [details] Patch Attachment 201830 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/477472

Build Bot

Comment 14 2013-05-15 08:03:20 PDT

Comment on attachment 201830 [details] Patch Attachment 201830 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/477471

EFL EWS Bot

Comment 15 2013-05-15 08:08:12 PDT

Comment on attachment 201830 [details] Patch Attachment 201830 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/477475

Anders Carlsson

Comment 16 2013-05-15 08:17:06 PDT

Created attachment 201832 [details] Patch

EFL EWS Bot

Comment 17 2013-05-15 08:22:46 PDT

Comment on attachment 201832 [details] Patch Attachment 201832 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/468889

EFL EWS Bot

Comment 18 2013-05-15 08:23:54 PDT

Comment on attachment 201832 [details] Patch Attachment 201832 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/477480

Early Warning System Bot

Comment 19 2013-05-15 08:24:30 PDT

Comment on attachment 201832 [details] Patch Attachment 201832 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/467913

Early Warning System Bot

Comment 20 2013-05-15 08:26:02 PDT

Comment on attachment 201832 [details] Patch Attachment 201832 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/477481

Anders Carlsson

Comment 21 2013-05-15 08:30:51 PDT

Created attachment 201833 [details] Patch

EFL EWS Bot

Comment 22 2013-05-15 08:36:23 PDT

Comment on attachment 201833 [details] Patch Attachment 201833 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/471596

Build Bot

Comment 23 2013-05-15 08:57:11 PDT

Comment on attachment 201833 [details] Patch Attachment 201833 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/476554

Anders Carlsson

Comment 24 2013-05-15 09:20:26 PDT

Created attachment 201842 [details] Patch

Build Bot

Comment 25 2013-05-15 09:49:59 PDT

Comment on attachment 201842 [details] Patch Attachment 201842 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/475553

kov's GTK+ EWS bot

Comment 26 2013-05-15 09:56:53 PDT

Comment on attachment 201842 [details] Patch Attachment 201842 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/480104

Anders Carlsson

Comment 27 2013-05-15 10:16:32 PDT

Created attachment 201850 [details] Patch

Anders Carlsson

Comment 28 2013-05-15 12:39:44 PDT

Created attachment 201865 [details] Patch

Anders Carlsson

Comment 29 2013-05-15 12:47:29 PDT

Committed r150140: <http://trac.webkit.org/changeset/150140>

Note You need to log in before you can comment on or make changes to this bug.