Bug 116036

Summary:

[Mac] Move setDragImage from ClipboardMac to PasteboardMac

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

Platform

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, esprehn+autocc, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

All

Bug Depends on:

Bug Blocks:

115980

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2	none
Patch	andersca: review+, andersca: commit-queue-

Darin Adler

Reported 2013-05-13 08:29:24 PDT

[Mac] Move setDragImage from ClipboardMac to PasteboardMac

Attachments
Patch (14.42 KB, patch) 2013-05-13 09:35 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (1.49 MB, application/zip) 2013-05-13 12:36 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (791.59 KB, application/zip) 2013-05-13 18:00 PDT, Build Bot	no flags	Details
Patch (14.38 KB, patch) 2013-05-14 19:47 PDT, Darin Adler	andersca: review+ andersca: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2013-05-13 09:35:50 PDT

Created attachment 201577 [details] Patch

Build Bot

Comment 2 2013-05-13 12:36:29 PDT

Comment on attachment 201577 [details] Patch Attachment 201577 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/395893 New failing tests: fast/table/table-rowspan-height-distribution-in-rows.html fast/events/drag-display-none-element.html editing/selection/drag-start-event-client-x-y.html fast/events/clear-drag-state.html fast/events/drag-and-drop-set-drag-data-arguments.html fast/events/mousedown-inside-dragstart-should-not-cause-crash.html editing/pasteboard/drag-and-drop-inputimage-contenteditable.html fast/events/dragging-mouse-moves.html fast/events/drag-and-drop-fire-drag-dragover.html editing/selection/user-drag-element-and-user-select-none.html fast/css-generated-content/drag-state.html fast/events/dropzone-003.html fast/events/remove-target-with-shadow-in-drag.html fast/events/drag-and-drop-dataTransfer-types-nocrash.html fast/events/drag-and-drop.html fast/events/dropzone-002.html fast/events/bogus-dropEffect-effectAllowed.html fast/events/dropzone-001.html editing/pasteboard/drag-and-drop-objectimage-contenteditable.html fast/css/user-drag-none.html

Build Bot

Comment 3 2013-05-13 12:36:30 PDT

Created attachment 201622 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.2

Build Bot

Comment 4 2013-05-13 18:00:09 PDT

Comment on attachment 201577 [details] Patch Attachment 201577 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/470008 New failing tests: fast/events/clear-drag-state.html fast/events/drag-and-drop-set-drag-data-arguments.html fast/events/mousedown-inside-dragstart-should-not-cause-crash.html fast/events/dragging-mouse-moves.html editing/selection/user-drag-element-and-user-select-none.html fast/css-generated-content/drag-state.html editing/selection/drag-start-event-client-x-y.html fast/css/user-drag-none.html

Build Bot

Comment 5 2013-05-13 18:00:11 PDT

Created attachment 201657 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2

Darin Adler

Comment 6 2013-05-13 18:02:30 PDT

Looks like I have some work to do! I had no idea all those dragging tests were failing.

Darin Adler

Comment 7 2013-05-14 19:25:59 PDT

Just one backwards boolean check. Re-uploading shortly.

Darin Adler

Comment 8 2013-05-14 19:47:56 PDT

Created attachment 201783 [details] Patch

Anders Carlsson

Comment 9 2013-05-14 21:16:29 PDT

Comment on attachment 201783 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201783&action=review > Source/WebCore/dom/Clipboard.cpp:47 > + void stopLoading(CachedResourceHandle<CachedImage>&); Missing newline

Darin Adler

Comment 10 2013-05-14 21:27:06 PDT

Committed r150100: <http://trac.webkit.org/changeset/150100>

Note You need to log in before you can comment on or make changes to this bug.