Bug 116027

Summary: Rename BarInfo to BarProp and remove [NoInterfaceObject]
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, arv, benjamin, buildbot, commit-queue, esprehn+autocc, gyuyoung.kim, haraken, laszlo.gombos, rakuco, rniwa, zan
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://www.w3.org/html/wg/drafts/html/master/browsers.html#barprop
Attachments:
Description Flags
Patch
buildbot: commit-queue-
Patch
kling: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion
none
Patch for landing
none
Patch for landing none

Description Chris Dumez 2013-05-13 04:37:23 PDT 
According to specification [1], BarInfo should be called BarProp and should not have [NoInterfaceObject] extended attribute.

Both Firefox and Blink follow the specification.

[1] http://www.w3.org/html/wg/drafts/html/master/browsers.html#barprop

Corresponding Blink patch: https://src.chromium.org/viewvc/blink?view=rev&revision=150032
Comment 1 Chris Dumez 2013-05-13 05:01:54 PDT 
Created attachment 201548 [details]
Patch
Comment 2 WebKit Commit Bot 2013-05-13 05:04:40 PDT 
Attachment 201548 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/platform/efl/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/platform/gtk/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/platform/mac-lion/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/platform/qt/fast/js/global-constructors-attributes-expected.txt', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/DerivedSources.cpp', u'Source/WebCore/DerivedSources.pri', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.order', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/gobject/GNUmakefile.am', u'Source/WebCore/page/BarInfo.cpp', u'Source/WebCore/page/BarInfo.h', u'Source/WebCore/page/BarInfo.idl', u'Source/WebCore/page/BarProp.cpp', u'Source/WebCore/page/BarProp.h', u'Source/WebCore/page/BarProp.idl', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/DOMWindow.h', u'Source/WebCore/page/DOMWindow.idl']" exit_code: 1
Source/WebCore/page/DOMWindow.h:38:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2013-05-13 05:33:52 PDT 
Comment on attachment 201548 [details]
Patch

Attachment 201548 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/465284
Comment 4 Build Bot 2013-05-13 05:40:13 PDT 
Comment on attachment 201548 [details]
Patch

Attachment 201548 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/461721
Comment 5 Chris Dumez 2013-05-13 06:03:16 PDT 
Created attachment 201552 [details]
Patch

Should fix mac and win builds.
Comment 6 WebKit Commit Bot 2013-05-13 06:06:27 PDT 
Attachment 201552 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/platform/efl/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/platform/gtk/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/platform/mac-lion/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/platform/qt/fast/js/global-constructors-attributes-expected.txt', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/DerivedSources.cpp', u'Source/WebCore/DerivedSources.make', u'Source/WebCore/DerivedSources.pri', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.order', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/gobject/GNUmakefile.am', u'Source/WebCore/page/BarInfo.cpp', u'Source/WebCore/page/BarInfo.h', u'Source/WebCore/page/BarInfo.idl', u'Source/WebCore/page/BarProp.cpp', u'Source/WebCore/page/BarProp.h', u'Source/WebCore/page/BarProp.idl', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/DOMWindow.h', u'Source/WebCore/page/DOMWindow.idl']" exit_code: 1
Source/WebCore/page/DOMWindow.h:38:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Andreas Kling 2013-05-13 07:03:55 PDT 
Comment on attachment 201552 [details]
Patch

r=me!
Comment 8 Build Bot 2013-05-13 07:22:15 PDT 
Comment on attachment 201552 [details]
Patch

Attachment 201552 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/467174

New failing tests:
http/tests/security/cross-frame-access-put.html
fast/dom/Window/window-lookup-precedence.html
fast/loader/window-properties-restored-from-page-cache.html
Comment 9 Build Bot 2013-05-13 07:22:19 PDT 
Created attachment 201563 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.2
Comment 10 Chris Dumez 2013-05-13 08:23:59 PDT 
Created attachment 201569 [details]
Patch for landing
Comment 11 WebKit Commit Bot 2013-05-13 08:27:33 PDT 
Attachment 201569 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt', u'LayoutTests/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/fast/loader/window-properties-restored-from-page-cache-expected.txt', u'LayoutTests/http/tests/security/cross-frame-access-put-expected.txt', u'LayoutTests/platform/efl/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/platform/gtk/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/platform/mac-lion/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/platform/qt/fast/js/global-constructors-attributes-expected.txt', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/DerivedSources.cpp', u'Source/WebCore/DerivedSources.make', u'Source/WebCore/DerivedSources.pri', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.order', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/gobject/GNUmakefile.am', u'Source/WebCore/page/BarInfo.cpp', u'Source/WebCore/page/BarInfo.h', u'Source/WebCore/page/BarInfo.idl', u'Source/WebCore/page/BarProp.cpp', u'Source/WebCore/page/BarProp.h', u'Source/WebCore/page/BarProp.idl', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/DOMWindow.h', u'Source/WebCore/page/DOMWindow.idl']" exit_code: 1
Source/WebCore/page/DOMWindow.h:38:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 Chris Dumez 2013-05-13 14:00:15 PDT 
Created attachment 201630 [details]
Patch for landing

Update mac specific expectation to make mac-ews happy.
Comment 13 WebKit Commit Bot 2013-05-13 14:03:02 PDT 
Attachment 201630 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt', u'LayoutTests/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/fast/loader/window-properties-restored-from-page-cache-expected.txt', u'LayoutTests/http/tests/security/cross-frame-access-put-expected.txt', u'LayoutTests/platform/efl/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/platform/gtk/fast/dom/Window/window-lookup-precedence-expected.txt', u'LayoutTests/platform/gtk/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/platform/mac-lion/fast/js/global-constructors-attributes-expected.txt', u'LayoutTests/platform/mac/fast/dom/Window/window-lookup-precedence-expected.txt', u'LayoutTests/platform/qt/fast/js/global-constructors-attributes-expected.txt', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/DerivedSources.cpp', u'Source/WebCore/DerivedSources.make', u'Source/WebCore/DerivedSources.pri', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.order', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/gobject/GNUmakefile.am', u'Source/WebCore/page/BarInfo.cpp', u'Source/WebCore/page/BarInfo.h', u'Source/WebCore/page/BarInfo.idl', u'Source/WebCore/page/BarProp.cpp', u'Source/WebCore/page/BarProp.h', u'Source/WebCore/page/BarProp.idl', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/DOMWindow.h', u'Source/WebCore/page/DOMWindow.idl']" exit_code: 1
Source/WebCore/page/DOMWindow.h:38:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 14 WebKit Commit Bot 2013-05-13 18:00:18 PDT 
Comment on attachment 201630 [details]
Patch for landing

Clearing flags on attachment: 201630

Committed r150045: <http://trac.webkit.org/changeset/150045>
Comment 15 WebKit Commit Bot 2013-05-13 18:00:23 PDT 
All reviewed patches have been landed.  Closing bug.