Summary: | CLoop llint backend should not use the d8 register as scratch register | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Peter Wang <PeterHWang> | ||||||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, fpizlo, ossy, rgabor, rniwa, zherczeg | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Peter Wang
2013-05-13 02:43:19 PDT
Created attachment 201539 [details]
Patch
(In reply to comment #1) > Created an attachment (id=201539) [details] > Patch Just upload this patch to propose to fix the remaining part. LGTM, but it would be better if a JSC expert can review it. Comment on attachment 201539 [details] Patch Attachment 201539 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/467317 New failing tests: editing/style/5065910.html Created attachment 201641 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2
ping? Created attachment 202760 [details]
Patch
(In reply to comment #6) > ping Sorry to keep waiting. It's weird. My local MAC build can pass the case mentioned as failed case in comment#4. I just re-upload patch to have a try again. Comment on attachment 202760 [details]
Patch
Try to resubmit the patch since the author believes last regression is not related to this patch.
Comment on attachment 202760 [details] Patch Rejecting attachment 202760 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 202760, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Csaba Osztrogonac found in /Volumes/Data/EWS/WebKit/Source/JavaScriptCore/ChangeLog does not appear to be a valid reviewer according to committers.py. /Volumes/Data/EWS/WebKit/Source/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/682007 Created attachment 202769 [details]
Patch
Comment on attachment 202769 [details]
Patch
resubmit after fixing the typo of the Reviewer.
The commit-queue encountered the following flaky tests while processing attachment 202769 [details]: svg/batik/text/textAnchor.svg bug 116285 (authors: darin@apple.com and zimmermann@kde.org) svg/batik/text/textEffect3.svg bug 116521 (authors: darin@apple.com and zimmermann@kde.org) media/event-queue-crash.html bug 114177 (author: shinyak@chromium.org) media/video-zoom.html bug 116704 (authors: fischman@chromium.org, jamesr@chromium.org, rniwa@webkit.org, and vrk@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 202769 [details] Patch Clearing flags on attachment: 202769 Committed r150630: <http://trac.webkit.org/changeset/150630> All reviewed patches have been landed. Closing bug. |