Bug 116018 – [WK2] PluginInformation.cpp fails to build because of missing ENABLE(NETSCAPE_PLUGIN_API) guard

• Component: New Bugs
• Status: RESOLVED FIXED

[Zoltan Arvai]

New file Shared/Plugins/Netscape/PluginInformation.cpp landed in http://trac.webkit.org/changeset/149904 includes WebKit2/UIProcess/Plugins/PluginInfoStore.h and refers to it in line 103 with:
 map.set(pluginInformationDefaultLoadPolicyKey(), WebUInt64::create(toWKPluginLoadPolicy(PluginInfoStore::policyForPlugin(plugin))));

If NETSCAPE_PLUGIN_API is not enabled, then the build will fail, because ENABLE(NETSCAPE_PLUGIN_API) guarded in PluginInfoStore.h but not in PluginInformation.cpp. 

It seems that happened on Qt Mountain Lion bot:

/Users/admin/work/WebKit-BuildSlave/qt-mountainlion-release/build/Source/WebKit2/Shared/Plugins/Netscape/PluginInformation.cpp:103:93: error: use of undeclared identifier 'PluginInfoStore'
    map.set(pluginInformationDefaultLoadPolicyKey(), WebUInt64::create(toWKPluginLoadPolicy(PluginInfoStore::policyForPlugin(plugin))));

[Andras Becsi]

Created attachment 201821 [details]
Patch

[Jocelyn Turcotte]

Comment on attachment 201821 [details]
Patch

Ideally it feels like the whole file and its header should also be guarded, but WebPageProxy::didFailToInitializePlugin is one use that would difficult to wrap.
So I guess it's fine to guard it that way, LGTM.

[Andras Becsi]

Committed r150178: <http://trac.webkit.org/changeset/150178>