Summary: | [Win] REGRESSION(r149944): mmap is not available on Windows | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zoltan Arvai <zarvai> | ||||||||||
Component: | New Bugs | Assignee: | Jocelyn Turcotte <jturcotte> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | andersca, commit-queue, hausmann, jturcotte, kadam, ossy, rakuco, sam | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 115970 | ||||||||||||
Attachments: |
|
Description
Zoltan Arvai
2013-05-13 01:08:45 PDT
(In reply to comment #0) > After r149944 Qt Win build is failing: > Can you check it, please? Zoltán, Apple isn't responsible to fix any Qt-WK2 related build breakages. So it would be great if you can check and fix it yourself instead of asking others to do it. ;-) I found similar things in WTF/wtf/TCSystemAlloc.cpp where #if guards are used for MMAP and VIRTUALALLOC capable ports. Created attachment 201572 [details]
Patch
Attachment 201572 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.cpp']" exit_code: 1
Source/WebKit2/ChangeLog:8: Line contains tab character. [whitespace/tab] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 201575 [details]
Patch
Fix the style.
Comment on attachment 201575 [details]
Patch
There’s no reason to call VirtualAlloc/VirtualFree on Windows; you can keep calling malloc/free.
Created attachment 201586 [details]
Patch
Use fastAlloc instead of VirtualAlloc and use mmap only on OS(DARWIN).
Created attachment 201587 [details]
Patch
Reword the ChangeLog.
Comment on attachment 201587 [details] Patch Clearing flags on attachment: 201587 Committed r150079: <http://trac.webkit.org/changeset/150079> All reviewed patches have been landed. Closing bug. |