Summary: | [Mac] Move clearData from ClipboardMac to PasteboardMac | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
Component: | Platform | Assignee: | Darin Adler <darin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 115980 | ||||||
Attachments: |
|
Description
Darin Adler
2013-05-12 19:29:50 PDT
Created attachment 201520 [details]
Patch
Comment on attachment 201520 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201520&action=review r=me > Source/WebCore/platform/mac/PasteboardMac.mm:606 > + if (qType == "url") else if (I know you're just moving this.) Committed r149977: <http://trac.webkit.org/changeset/149977> (In reply to comment #2) > > Source/WebCore/platform/mac/PasteboardMac.mm:606 > > + if (qType == "url") > > else if I’ll do that in a separate patch. (In reply to comment #4) > (In reply to comment #2) > > > Source/WebCore/platform/mac/PasteboardMac.mm:606 > > > + if (qType == "url") > > > > else if > > I’ll do that in a separate patch. Nah, on second thought I prefer not to try to improve the style on this old code right now. It needs a lot of work, and the else is the least of it. |