Bug 116000

Summary: [Mac] Move clearData from ClipboardMac to PasteboardMac
Product: WebKit Reporter: Darin Adler <darin>
Component: PlatformAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Bug Depends on:    
Bug Blocks: 115980    
Attachments:
Description Flags
Patch kling: review+

Darin Adler
Reported 2013-05-12 19:29:50 PDT
[Mac] Move clearData from ClipboardMac to PasteboardMac
Attachments
Patch (9.78 KB, patch)
2013-05-12 19:33 PDT, Darin Adler 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2013-05-12 19:33:48 PDT
Created attachment 201520 [details] Patch
Andreas Kling
Comment 2 2013-05-12 19:39:52 PDT
Comment on attachment 201520 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201520&action=review r=me > Source/WebCore/platform/mac/PasteboardMac.mm:606 > + if (qType == "url") else if (I know you're just moving this.)
Darin Adler
Comment 3 2013-05-12 19:40:56 PDT
Committed r149977: <http://trac.webkit.org/changeset/149977>
Darin Adler
Comment 4 2013-05-12 21:03:17 PDT
(In reply to comment #2) > > Source/WebCore/platform/mac/PasteboardMac.mm:606 > > + if (qType == "url") > > else if I’ll do that in a separate patch.
Darin Adler
Comment 5 2013-05-12 22:04:29 PDT
(In reply to comment #4) > (In reply to comment #2) > > > Source/WebCore/platform/mac/PasteboardMac.mm:606 > > > + if (qType == "url") > > > > else if > > I’ll do that in a separate patch. Nah, on second thought I prefer not to try to improve the style on this old code right now. It needs a lot of work, and the else is the least of it.
Note You need to log in before you can comment on or make changes to this bug.