Bug 116000

Summary:

[Mac] Move clearData from ClipboardMac to PasteboardMac

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

Platform

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

All

Bug Depends on:

Bug Blocks:

115980

Attachments:

Description	Flags
Patch	kling: review+

Description Darin Adler 2013-05-12 19:29:50 PDT

[Mac] Move clearData from ClipboardMac to PasteboardMac

Comment 1 Darin Adler 2013-05-12 19:33:48 PDT

Created attachment 201520 [details]
Patch

Comment 2 Andreas Kling 2013-05-12 19:39:52 PDT

Comment on attachment 201520 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201520&action=review

r=me

> Source/WebCore/platform/mac/PasteboardMac.mm:606
> +    if (qType == "url")

else if
(I know you're just moving this.)

Comment 3 Darin Adler 2013-05-12 19:40:56 PDT

Committed r149977: <http://trac.webkit.org/changeset/149977>

Comment 4 Darin Adler 2013-05-12 21:03:17 PDT

(In reply to comment #2)
> > Source/WebCore/platform/mac/PasteboardMac.mm:606
> > +    if (qType == "url")
> 
> else if

I’ll do that in a separate patch.

Comment 5 Darin Adler 2013-05-12 22:04:29 PDT

(In reply to comment #4)
> (In reply to comment #2)
> > > Source/WebCore/platform/mac/PasteboardMac.mm:606
> > > +    if (qType == "url")
> > 
> > else if
> 
> I’ll do that in a separate patch.

Nah, on second thought I prefer not to try to improve the style on this old code right now. It needs a lot of work, and the else is the least of it.