Summary: | Save sheet on the Web Inspector does not come out from under the toolbar | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Timothy Hatcher <timothy> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, cdumez, commit-queue, graouts, gyuyoung.kim, joepeck, rakuco, timothy | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Timothy Hatcher
2013-05-12 17:09:52 PDT
Created attachment 201513 [details]
Patch
Comment on attachment 201513 [details]
Patch
Looks good to me. Can we get an owner to r+ the WK2 part (very simple).
Comment on attachment 201513 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201513&action=review > Source/WebCore/ChangeLog:10 > + (InspectorFrontendClient): It's best to remove such erroneous prepare-ChangeLog output, as it doesn't help people who are reading ChangeLogs. One day, someone should fix prepare-ChangeLog. Comment on attachment 201513 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201513&action=review > Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.h:89 > + virtual void setToolbarHeight(unsigned); OVERRIDE > Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h:96 > + virtual void setToolbarHeight(unsigned); OVERRIDE > Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h:113 > + virtual void setToolbarHeight(unsigned); OVERRIDE > Source/WebKit/qt/WebCoreSupport/InspectorClientQt.h:99 > + virtual void setToolbarHeight(unsigned); OVERRIDE > Source/WebKit/win/WebCoreSupport/WebInspectorClient.h:112 > + virtual void setToolbarHeight(unsigned); OVERRIDE > Source/WebKit2/UIProcess/WebInspectorProxy.h:130 > +#if PLATFORM(MAC) > + void setToolbarHeight(unsigned height) { platformSetToolbarHeight(height); } > +#else > + void setToolbarHeight(unsigned) { } > +#endif > + Instead of this, you should have both setToolbarHeight and platformSetToolbarHeight defined for both platforms and platformSetToolbarHeight() implemented as { notImplemented(); } I sign off on this with the comments above. |