Bug 115989

Summary: Remove Complex.h from WTF
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, benjamin, buildbot, cmarcelo, commit-queue, eflews.bot, eric.carlson, glenn, gyuyoung.kim, gyuyoung.kim, jer.noble, philn, rakuco, rniwa, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch bdakin: review+

Anders Carlsson
Reported 2013-05-12 11:01:57 PDT
Remove Complex.h from WTF
Attachments
Patch (19.24 KB, patch)
2013-05-12 11:07 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (19.45 KB, patch)
2013-05-12 11:33 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (19.52 KB, patch)
2013-05-12 12:06 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (19.76 KB, patch)
2013-05-12 13:35 PDT, Anders Carlsson 		bdakin: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-05-12 11:07:39 PDT
Created attachment 201498 [details] Patch
EFL EWS Bot
Comment 2 2013-05-12 11:29:58 PDT
Comment on attachment 201498 [details] Patch Attachment 201498 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/427597
EFL EWS Bot
Comment 3 2013-05-12 11:31:47 PDT
Comment on attachment 201498 [details] Patch Attachment 201498 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/464008
Anders Carlsson
Comment 4 2013-05-12 11:33:22 PDT
Created attachment 201499 [details] Patch
EFL EWS Bot
Comment 5 2013-05-12 11:43:17 PDT
Comment on attachment 201499 [details] Patch Attachment 201499 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/297513
EFL EWS Bot
Comment 6 2013-05-12 11:47:51 PDT
Comment on attachment 201499 [details] Patch Attachment 201499 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/395538
Chris Dumez
Comment 7 2013-05-12 11:55:10 PDT
Comment on attachment 201499 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201499&action=review > Source/WebCore/Modules/webaudio/RealtimeAnalyser.cpp:-38 > -#include <wtf/Complex.h> Needs to be replaced by #include <complex> to fix EFL build.
Andreas Kling
Comment 8 2013-05-12 12:04:00 PDT
Comment on attachment 201499 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201499&action=review r=me with EFL build fixed. > Source/WTF/ChangeLog:9 > + The header is used by three files in WebCore, so just use std::complex<double> and std::poolar directly. poolar :|
Anders Carlsson
Comment 9 2013-05-12 12:06:24 PDT
Created attachment 201502 [details] Patch
Build Bot
Comment 10 2013-05-12 12:44:13 PDT
Comment on attachment 201502 [details] Patch Attachment 201502 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/427608
Anders Carlsson
Comment 11 2013-05-12 13:35:59 PDT
Created attachment 201508 [details] Patch
Anders Carlsson
Comment 12 2013-05-12 14:27:12 PDT
Committed r149970: <http://trac.webkit.org/changeset/149970>
Note You need to log in before you can comment on or make changes to this bug.