Bug 115965

Summary: [GTK] Move defines that will never be configured to Platform.h
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, laszlo.gombos
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 115966    
Attachments:
Description Flags
Patch kling: review+

Description Martin Robinson 2013-05-11 11:47:07 PDT
Instead of putting defines that are never configured (think USE_HARFBUZZ) into the autoconf configuration file, we should just put them in Platform.h. This has a couple benefits. It makes it easier for developers from other ports to see what GTK+ uses and it also lets us share the defines with the cmake build.
Comment 1 Martin Robinson 2013-05-11 11:53:50 PDT
Created attachment 201467 [details]
Patch
Comment 2 Laszlo Gombos 2013-05-12 09:36:52 PDT
Great !
Comment 3 Martin Robinson 2013-05-12 11:10:05 PDT
Committed r149966: <http://trac.webkit.org/changeset/149966>