Bug 115961

Summary:

Fix several style warnings in generated bindings

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Bindings

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, benjamin, commit-queue, eric.carlson, glenn, haraken, jer.noble, jsbell, laszlo.gombos, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

115959

Attachments:

Description	Flags
Patch	haraken: review+, commit-queue: commit-queue-
Patch for landing	none

Description Chris Dumez 2013-05-11 10:41:29 PDT

The generating bindings in Source/WebCore/bindings/scripts/test/ do not always follow the WebKit coding style and the style script is complaining when updating them.

Comment 1 Chris Dumez 2013-05-11 11:09:52 PDT

Created attachment 201464 [details]
Patch

Comment 2 WebKit Commit Bot 2013-05-11 11:18:10 PDT

Comment on attachment 201464 [details]
Patch

Rejecting attachment 201464 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--non-interactive', 201464, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/417518

Comment 3 Chris Dumez 2013-05-11 11:24:21 PDT

Created attachment 201466 [details]
Patch for landing

Comment 4 WebKit Commit Bot 2013-05-11 12:07:14 PDT

Comment on attachment 201466 [details]
Patch for landing

Clearing flags on attachment: 201466

Committed r149935: <http://trac.webkit.org/changeset/149935>

Comment 5 WebKit Commit Bot 2013-05-11 12:07:19 PDT

All reviewed patches have been landed.  Closing bug.