Bug 115961 - Fix several style warnings in generated bindings
Summary: Fix several style warnings in generated bindings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 115959
  Show dependency treegraph
 
Reported: 2013-05-11 10:41 PDT by Chris Dumez
Modified: 2013-05-11 12:07 PDT (History)
10 users (show)

See Also:


Attachments
Patch (46.68 KB, patch)
2013-05-11 11:09 PDT, Chris Dumez
haraken: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (46.71 KB, patch)
2013-05-11 11:24 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-05-11 10:41:29 PDT
The generating bindings in Source/WebCore/bindings/scripts/test/ do not always follow the WebKit coding style and the style script is complaining when updating them.
Comment 1 Chris Dumez 2013-05-11 11:09:52 PDT
Created attachment 201464 [details]
Patch
Comment 2 WebKit Commit Bot 2013-05-11 11:18:10 PDT
Comment on attachment 201464 [details]
Patch

Rejecting attachment 201464 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--non-interactive', 201464, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/417518
Comment 3 Chris Dumez 2013-05-11 11:24:21 PDT
Created attachment 201466 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2013-05-11 12:07:14 PDT
Comment on attachment 201466 [details]
Patch for landing

Clearing flags on attachment: 201466

Committed r149935: <http://trac.webkit.org/changeset/149935>
Comment 5 WebKit Commit Bot 2013-05-11 12:07:19 PDT
All reviewed patches have been landed.  Closing bug.