Bug 115955

Summary:

Implement .onended event listener for AudioBufferSourceNode and OscillatorNode

Product:

WebKit

Reporter:

Praveen Jadhav <praveen.j>

Component:

Web Audio

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

cdumez, commit-queue, crogers, dev_sachin, eric.carlson, esprehn+autocc, glenn, jer.noble, s.choi

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	crogers: review-

Praveen Jadhav

Reported 2013-05-11 02:25:32 PDT

AudioBufferSourceNode and OscillatorNode should sent .onended event as per the latest webaudio specifications.

Attachments
Patch (18.31 KB, patch) 2013-05-11 02:33 PDT, Praveen Jadhav	crogers: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Praveen Jadhav

Comment 1 2013-05-11 02:33:03 PDT

Created attachment 201454 [details] Patch Patch for onended event implementation in AudioBufferSourceNode and OscillatorNode.

WebKit Commit Bot

Comment 2 2013-05-11 02:35:02 PDT

Attachment 201454 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/webaudio/audiobuffersource-stop-expected.txt', u'LayoutTests/webaudio/audiobuffersource-stop.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp', u'Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h', u'Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl', u'Source/WebCore/Modules/webaudio/OscillatorNode.cpp', u'Source/WebCore/Modules/webaudio/OscillatorNode.h', u'Source/WebCore/Modules/webaudio/OscillatorNode.idl', u'Source/WebCore/dom/EventTarget.h', u'Source/WebCore/dom/EventTargetFactory.in']" exit_code: 1 Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp:357: One line control clauses should not use braces. [whitespace/braces] [4] Source/WebCore/Modules/webaudio/OscillatorNode.cpp:354: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 2 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Rogers

Comment 3 2013-05-11 10:24:14 PDT

Comment on attachment 201454 [details] Patch Thanks Praveen, but we're working on a separate patch to simply make AudioNode an EventTarget. Then we need to create special optimized code to not fire an event if there are no event listeners to avoid calling callOnMainThread()

Praveen Jadhav

Comment 4 2013-05-11 19:57:04 PDT

(In reply to comment #3) > (From update of attachment 201454 [details]) > Thanks Praveen, but we're working on a separate patch to simply make AudioNode an EventTarget. Then we need to create special optimized code to not fire an event if there are no event listeners to avoid calling callOnMainThread() That would be really nice not to call callOnMainThread() unnecessarily if event listener isn't present. As of now, ScriptProcessorNode too has this issue and can be avoided with your approach. Will wait for your patch.. :-)

Praveen Jadhav

Comment 5 2013-05-29 02:36:06 PDT

*** This bug has been marked as a duplicate of bug 116798 ***

Note You need to log in before you can comment on or make changes to this bug.