Bug 115938

Summary: Rename StructureCheckHoistingPhase to TypeCheckHoistingPhase
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Mark Hahnenberg 2013-05-10 14:51:53 PDT
We're going to add some more types of check hoisting soon, so let's have the right name here.
Comment 1 Mark Hahnenberg 2013-05-10 14:58:03 PDT
Created attachment 201428 [details]
Patch
Comment 2 WebKit Commit Bot 2013-05-10 14:59:12 PDT
Attachment 201428 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/Target.pri', u'Source/JavaScriptCore/dfg/DFGDriver.cpp', u'Source/JavaScriptCore/dfg/DFGStructureCheckHoistingPhase.cpp', u'Source/JavaScriptCore/dfg/DFGStructureCheckHoistingPhase.h', u'Source/JavaScriptCore/dfg/DFGTypeCheckHoistingPhase.cpp', u'Source/JavaScriptCore/dfg/DFGTypeCheckHoistingPhase.h']" exit_code: 1
Source/JavaScriptCore/dfg/DFGTypeCheckHoistingPhase.cpp:239:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Hahnenberg 2013-05-10 16:14:31 PDT
Committed r149911: <http://trac.webkit.org/changeset/149911>
Comment 4 Mark Hahnenberg 2013-05-11 17:26:16 PDT
Landed on the branch as well.