Bug 115935

Summary: [Windows] Allow VS2010 Build to use VS2005 Support Libraries
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, roger_fong, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Brent Fulgham
Reported 2013-05-10 14:10:31 PDT
Some of the non-open source libraries used by the Apple Windows build are currently built using VS2005. These libraries link again MSVCR80.dll, but do not include a manifest that tells Windows which of the myriad of MSVCR80.dll files to use. Consequently, Windows throws up its hands and gives up. This patch incorporates a manifest entry in the WinLauncher tool that tells it which specific version of MSVCR80.dll it should use when trying to run. This avoids problems when running a VS2010 WebKit build with these current support libraries. In the future, this manifest entry could be removed. Even if we forget, it should be harmless as long as we do not someday switch to some other MSVCR80.dll version (unlikely).
Attachments
Patch (3.75 KB, patch)
2013-05-10 14:14 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (3.91 KB, patch)
2013-05-10 15:06 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2013-05-10 14:14:52 PDT
Created attachment 201425 [details] Patch
Brent Fulgham
Comment 2 2013-05-10 15:06:14 PDT
Created attachment 201429 [details] Patch
Radar WebKit Bug Importer
Comment 3 2013-05-10 16:23:38 PDT
<rdar://problem/13866067>
WebKit Commit Bot
Comment 4 2013-05-10 17:45:34 PDT
Comment on attachment 201429 [details] Patch Clearing flags on attachment: 201429 Committed r149916: <http://trac.webkit.org/changeset/149916>
WebKit Commit Bot
Comment 5 2013-05-10 17:45:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.