Bug 115914

Summary: [GTK] Remove unnecessary GTK_CHECK_VERSION #ifdefs
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn, gustavo, jer.noble, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mrobinson: review+

Carlos Garcia Campos
Reported 2013-05-10 09:31:33 PDT
We already bumped to gtk+ 3.6, so we can get rid of most of the #ifdefed code.
Attachments
Patch (49.85 KB, patch)
2013-05-10 10:35 PDT, Carlos Garcia Campos 		mrobinson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2013-05-10 10:35:45 PDT
Created attachment 201360 [details] Patch
WebKit Commit Bot
Comment 2 2013-05-10 10:37:10 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Martin Robinson
Comment 3 2013-05-10 11:25:27 PDT
Comment on attachment 201360 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201360&action=review > Source/WebCore/platform/graphics/gtk/FullscreenVideoControllerGtk.cpp:201 > - GdkCursor* cursor = blankCursor(); > - gdk_window_set_cursor(window, cursor); > + GRefPtr<GdkCursor> cursor = adoptGRef(gdk_cursor_new(GDK_BLANK_CURSOR)); > + gdk_window_set_cursor(window, cursor.get()); Nice!
Carlos Garcia Campos
Comment 4 2013-05-12 02:05:28 PDT
Committed r149952: <http://trac.webkit.org/changeset/149952>
Note You need to log in before you can comment on or make changes to this bug.