Bug 115891

Summary: Unify plug-in information dictionaries
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: eflews.bot, gyuyoung.kim, hugo.lima, webkit-ews
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 116018    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch andersca: review+, eflews.bot: commit-queue-

Sam Weinig
Reported 2013-05-09 22:41:00 PDT
Unify plug-in information dictionaries
Attachments
Patch (61.84 KB, patch)
2013-05-09 22:53 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (61.53 KB, patch)
2013-05-09 22:56 PDT, Sam Weinig 		andersca: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2013-05-09 22:53:15 PDT
Created attachment 201320 [details] Patch
Sam Weinig
Comment 2 2013-05-09 22:56:23 PDT
Created attachment 201321 [details] Patch
EFL EWS Bot
Comment 3 2013-05-09 23:04:48 PDT
Comment on attachment 201321 [details] Patch Attachment 201321 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/450058
Early Warning System Bot
Comment 4 2013-05-09 23:05:10 PDT
Comment on attachment 201321 [details] Patch Attachment 201321 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/450057
Anders Carlsson
Comment 5 2013-05-10 11:58:09 PDT
Comment on attachment 201321 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201321&action=review > Source/WebKit2/Shared/Plugins/Netscape/PluginInformation.cpp:99 > +void pluginModuleInformation(const PluginModuleInfo& plugin, ImmutableDictionary::MapType& map) Should be called get (or just return the map.
Sam Weinig
Comment 6 2013-05-10 13:45:25 PDT
Committed r149904: <http://trac.webkit.org/changeset/149904>
Hugo Parente Lima
Comment 7 2013-05-14 14:53:09 PDT
This patch broke compilation of ports not enabling NETSCAPE_PLUGIN_API due to the use of PluginInfoStore.
Note You need to log in before you can comment on or make changes to this bug.