Bug 115850

Summary:

Web Inspector: Remove Memory Distribution and Memory Snapshots Panels

Product:

WebKit

Reporter:

Seokju Kwon <seokju>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, timothy, webkit-ews

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

114998

Attachments:

Description	Flags
Patch	none
Patch	none

Seokju Kwon

Reported 2013-05-09 01:08:38 PDT

Removed the Memory Instrumentation Code after r148921. Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:363: WARNING - MemoryAgent.getProcessMemoryDistribution is never defined MemoryAgent.getProcessMemoryDistribution(true,didReceiveMemorySnapshot.bind(profileHeader)); Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:363: WARNING - Property getProcessMemoryDistribution never defined on MemoryAgent

Attachments
Patch (37.06 KB, patch) 2013-05-09 01:28 PDT, Seokju Kwon	no flags	Details Formatted Diff Diff
Patch (37.34 KB, patch) 2013-05-09 01:36 PDT, Seokju Kwon	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Seokju Kwon

Comment 1 2013-05-09 01:28:48 PDT

Created attachment 201171 [details] Patch

Early Warning System Bot

Comment 2 2013-05-09 01:33:44 PDT

Comment on attachment 201171 [details] Patch Attachment 201171 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/300081

Early Warning System Bot

Comment 3 2013-05-09 01:34:35 PDT

Comment on attachment 201171 [details] Patch Attachment 201171 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/418450

Seokju Kwon

Comment 4 2013-05-09 01:36:20 PDT

Created attachment 201172 [details] Patch

WebKit Commit Bot

Comment 5 2013-05-09 08:16:17 PDT

Comment on attachment 201172 [details] Patch Clearing flags on attachment: 201172 Committed r149807: <http://trac.webkit.org/changeset/149807>

WebKit Commit Bot

Comment 6 2013-05-09 08:16:19 PDT

All reviewed patches have been landed. Closing bug.

Joseph Pecoraro

Comment 7 2013-05-09 11:20:19 PDT

Comment on attachment 201172 [details] Patch I think there may be some layout tests that can be removed as well.

Seokju Kwon

Comment 8 2013-05-12 20:06:59 PDT

(In reply to comment #7) > (From update of attachment 201172 [details]) > I think there may be some layout tests that can be removed as well. @Joseph Pecoraro Thanks! I will file a new patch for it. :-)

Note You need to log in before you can comment on or make changes to this bug.