| Summary: | [BLACKBERRY]fix regression in Webpage | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | xuefeiren <xren> | ||||||
| Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, charles.wei, commit-queue, mawu, rwlbuis, xren | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
xuefeiren
2013-05-08 20:00:27 PDT
Created attachment 201130 [details]
Fix regression in WebPage and FrameLoaderClientBlackberry
Fix regression in WebPage and FrameLoaderClientBlackberry
Comment on attachment 201130 [details] Fix regression in WebPage and FrameLoaderClientBlackberry View in context: https://bugs.webkit.org/attachment.cgi?id=201130&action=review > Source/WebKit/blackberry/ChangeLog:5 > + Reviewed by Mary Wu. don't put here, it's internally review > Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:1192 > + requestCopy.setTargetType(BlackBerry::Platform::NetworkRequest::TargetIsDownload);/*forceDownload=true*/ obvious mistake, you use NetworkRequest to initiate ResourceRequest? Created attachment 201131 [details]
Fix regression in WebPage and FrameLoaderClientBlackberry
Fix regression in WebPage and FrameLoaderClientBlackberry
(In reply to comment #3) > Created an attachment (id=201131) [details] > Fix regression in WebPage and FrameLoaderClientBlackberry > > Fix regression in WebPage and FrameLoaderClientBlackberry ok Please do not r- patches if you are not a reviewer. Comment on attachment 201131 [details]
Fix regression in WebPage and FrameLoaderClientBlackberry
Ok.
Comment on attachment 201131 [details] Fix regression in WebPage and FrameLoaderClientBlackberry Clearing flags on attachment: 201131 Committed r149810: <http://trac.webkit.org/changeset/149810> All reviewed patches have been landed. Closing bug. |