Bug 115821

Summary: TextTrackCue should support empty content
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, esprehn+autocc, glenn, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch none

Description Eric Carlson 2013-05-08 13:09:11 PDT
'new TextTrackCue(start, end, "")' is valid but it currently creates a cue that causes WebKit to crash. 

Don't do that.
Comment 1 Radar WebKit Bug Importer 2013-05-08 13:09:42 PDT
<rdar://problem/13841113>
Comment 2 Eric Carlson 2013-05-08 13:19:57 PDT
Created attachment 201101 [details]
Proposed patch
Comment 3 Jer Noble 2013-05-08 13:25:56 PDT
Comment on attachment 201101 [details]
Proposed patch

Null checks are awesome.
Comment 4 WebKit Commit Bot 2013-05-08 13:52:43 PDT
Comment on attachment 201101 [details]
Proposed patch

Clearing flags on attachment: 201101

Committed r149766: <http://trac.webkit.org/changeset/149766>
Comment 5 WebKit Commit Bot 2013-05-08 13:52:45 PDT
All reviewed patches have been landed.  Closing bug.