Bug 115816

Summary: new-run-webkit-websocketserver doesn't work after Chromium removal
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, dpranke, jberlin, joepeck
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug joepeck: review+

Ryosuke Niwa
Reported 2013-05-08 12:10:44 PDT
new-run-webkit-websocketserver doesn't work after Chromium removal
Attachments
Fixes the bug (1.89 KB, patch)
2013-05-08 12:11 PDT, Ryosuke Niwa 		joepeck: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-05-08 12:11:11 PDT
Created attachment 201092 [details] Fixes the bug
Joseph Pecoraro
Comment 2 2013-05-08 12:16:01 PDT
Comment on attachment 201092 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=201092&action=review Looks good to me! Thanks. > Tools/Scripts/new-run-webkit-websocketserver:38 > +from webkitpy.port import platform_options Alphabetical order? Or does that style not matter in py. > Tools/Scripts/new-run-webkit-websocketserver:106 > # FIXME: Make this work with other ports as well. Seems like you can remove the FIXME now.
Ryosuke Niwa
Comment 3 2013-05-08 12:25:36 PDT
Committed r149757: <http://trac.webkit.org/changeset/149757>
Note You need to log in before you can comment on or make changes to this bug.