Bug 115815

Summary: Add missing USE(TEXTURE_MAPPER) guards
Product: WebKit Reporter: Rob Buis <rwlbuis>
Component: WebKit BlackBerryAssignee: Rob Buis <rwlbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, luiz, noam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch benjamin: review+, benjamin: commit-queue-

Rob Buis
Reported 2013-05-08 12:02:43 PDT
Note that BB port does not use texmap at all, so some parts of it must lack USE(TEXTURE_MAPPER) guards.
Attachments
Patch (10.81 KB, patch)
2013-05-08 12:26 PDT, Rob Buis 		benjamin: review+
benjamin: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2013-05-08 12:26:34 PDT
Created attachment 201095 [details] Patch
Benjamin Poulain
Comment 2 2013-05-09 02:02:47 PDT
Comment on attachment 201095 [details] Patch Ok in principle but fix the style before landing. In cpp files, I think it should be (please check): #include config #include mainheader #if Foobar [...] -- I also suggest you to comment the #endif with the condition when it makes sense.
Rob Buis
Comment 3 2013-05-09 08:50:06 PDT
(In reply to comment #2) > (From update of attachment 201095 [details]) > Ok in principle but fix the style before landing. > > In cpp files, I think it should be (please check): > #include config > #include mainheader > > #if Foobar > [...] I talked it over with Noam. We do not want to change the current structure of this too much for now, Noam could look at it once he is unblocked. > -- > I also suggest you to comment the #endif with the condition when it makes sense. Not a big fan of this, they can go stale, I left the patch as-is. Thanks for the review btw!
Rob Buis
Comment 4 2013-05-09 09:13:41 PDT
Committed r149813: <http://trac.webkit.org/changeset/149813>
Note You need to log in before you can comment on or make changes to this bug.