Bug 115802 – Allow blank spaces before colon (:) on CSS variable definition

• Component: CSS
• Status: RESOLVED FIXED

[Sergio Villar Senin]

Something like:

  :root {
      -webkit-var-mycolor : red;
  }

won't define a new CSS variable "mycolor" because there is a space before the colon.

[Sergio Villar Senin]

Created attachment 201071 [details]
Patch

[Sergio Villar Senin]

Created attachment 201072 [details]
Patch

[Darin Adler]

Comment on attachment 201072 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201072&action=review

r=me, but please do this without adding a new production

> Source/WebCore/css/CSSGrammar.y.in:1623
> -    VAR_DEFINITION ':' maybe_space expr prio {
> +    var_definition ':' maybe_space expr prio {
>  #if ENABLE_CSS_VARIABLES
>          parser->storeVariableDeclaration($1, parser->sinkFloatingValueList($4), $5);
>          $$ = true;

It’s unnecessary to add a new production for this. Instead you should just add the maybe_space to this production, and change $4 to $5 and $5 to $6.

[Sergio Villar Senin]

Committed r149740: <http://trac.webkit.org/changeset/149740>