Bug 115768

Summary: Store the quotes in the same allocation as the QuotesData object
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, esprehn+autocc, glenn
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Anders Carlsson
Reported 2013-05-07 16:32:26 PDT
Store the quotes in the same allocation as the QuotesData object
Attachments
Patch (5.36 KB, patch)
2013-05-07 16:35 PDT, Anders Carlsson 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-05-07 16:35:18 PDT
Created attachment 200992 [details] Patch
Andreas Kling
Comment 2 2013-05-07 16:52:30 PDT
Comment on attachment 200992 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200992&action=review r=me!!! > Source/WebCore/rendering/style/QuotesData.h:35 > +#if COMPILER(MSVC) > +#pragma warning(push) > +#pragma warning(disable: 4200) // Disable "zero-sized array in struct/union" warning > +#endif Maybe we should just do this globally. > Source/WebCore/rendering/style/QuotesData.h:51 > + unsigned m_numQuotes; m_numFoo doesn't sound very WebKitty. How about m_quoteCount?
Anders Carlsson
Comment 3 2013-05-07 18:47:09 PDT
Committed r149707: <http://trac.webkit.org/changeset/149707>
Darin Adler
Comment 4 2013-05-08 00:06:35 PDT
Anders, I have a fix for the regression here in my upcoming patch.
Note You need to log in before you can comment on or make changes to this bug.