Summary: | Store the quotes in the same allocation as the QuotesData object | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, darin, esprehn+autocc, glenn | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Anders Carlsson
2013-05-07 16:32:26 PDT
Created attachment 200992 [details]
Patch
Comment on attachment 200992 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200992&action=review r=me!!! > Source/WebCore/rendering/style/QuotesData.h:35 > +#if COMPILER(MSVC) > +#pragma warning(push) > +#pragma warning(disable: 4200) // Disable "zero-sized array in struct/union" warning > +#endif Maybe we should just do this globally. > Source/WebCore/rendering/style/QuotesData.h:51 > + unsigned m_numQuotes; m_numFoo doesn't sound very WebKitty. How about m_quoteCount? Committed r149707: <http://trac.webkit.org/changeset/149707> Anders, I have a fix for the regression here in my upcoming patch. |