Summary: | Fix memory leak after r149692 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Trivial | CC: | commit-queue, thorton | ||||
Priority: | P4 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.8 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 115766 | ||||||
Attachments: |
|
Description
Alex Christensen
2013-05-07 14:51:48 PDT
Created attachment 200981 [details]
Patch
Comment on attachment 200981 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200981&action=review > Tools/ChangeLog:3 > + fixed a memory leak introduced by bug 42324 by using a RetainPtr Probably should have been capitalized and probably reference the revision and not the bug. Comment on attachment 200981 [details] Patch Clearing flags on attachment: 200981 Committed r149697: <http://trac.webkit.org/changeset/149697> All reviewed patches have been landed. Closing bug. Comment on attachment 200981 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200981&action=review > Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:848 > + RetainPtr<WKDataRef> wkData = WKBundleFrameCopyWebArchive(frame); This doesn’t fix the leak. You need to call adoptCF to fix the leak. It was fixed properly under bug 115766. |