Bug 115760

Summary: Fix memory leak after r149692
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Trivial CC: commit-queue, thorton
Priority: P4    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.8   
Bug Depends on:    
Bug Blocks: 115766    
Attachments:
Description Flags
Patch none

Description Alex Christensen 2013-05-07 14:51:48 PDT
https://bugs.webkit.org/show_bug.cgi?id=42324 introduced a memory leak.  I fixed this leak by using RetainPtr<WKDataRef> instead of just WKDataRef.  I also added UNUSED_PARAM macros for non-cf builds.
Comment 1 Alex Christensen 2013-05-07 14:56:21 PDT
Created attachment 200981 [details]
Patch
Comment 2 Tim Horton 2013-05-07 14:59:43 PDT
Comment on attachment 200981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=200981&action=review

> Tools/ChangeLog:3
> +        fixed a memory leak introduced by bug 42324 by using a RetainPtr

Probably should have been capitalized and probably reference the revision and not the bug.
Comment 3 WebKit Commit Bot 2013-05-07 15:25:29 PDT
Comment on attachment 200981 [details]
Patch

Clearing flags on attachment: 200981

Committed r149697: <http://trac.webkit.org/changeset/149697>
Comment 4 WebKit Commit Bot 2013-05-07 15:25:31 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Darin Adler 2013-05-07 18:32:57 PDT
Comment on attachment 200981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=200981&action=review

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:848
> +    RetainPtr<WKDataRef> wkData = WKBundleFrameCopyWebArchive(frame);

This doesn’t fix the leak. You need to call adoptCF to fix the leak.
Comment 6 Mark Rowe (bdash) 2013-05-07 23:43:09 PDT
It was fixed properly under bug 115766.