Bug 115758

Summary: Support -webkit-system-font on OS X
Product: WebKit Reporter: Enrica Casucci <enrica>
Component: Layout and RenderingAssignee: Enrica Casucci <enrica>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, rniwa, simon.fraser
Priority: P2 Keywords: InRadar, WebExposed
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: Unspecified   
Attachments:
Description Flags
Patch dino: review+

Description Enrica Casucci 2013-05-07 14:10:59 PDT
We want to add a custom font family name to allow developers to reference the system UI font on OS X.

<rdar://problem/13433854>
Comment 1 Enrica Casucci 2013-05-07 14:13:36 PDT
Created attachment 200973 [details]
Patch
Comment 2 WebKit Commit Bot 2013-05-07 14:17:11 PDT
Attachment 200973 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/mac/fast/text/systemFont.html', u'LayoutTests/platform/mac/platform/mac/fast/text/systemFont-expected.png', u'LayoutTests/platform/mac/platform/mac/fast/text/systemFont-expected.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/mac/WebFontCache.mm']" exit_code: 1
LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Enrica Casucci 2013-05-07 14:27:14 PDT
I've updated the ChangeLog with the bug number, fixing the style issue.
Comment 4 Ryosuke Niwa 2013-05-07 14:40:27 PDT
Comment on attachment 200973 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=200973&action=review

> LayoutTests/ChangeLog:9
> +        * platform/mac/platform/mac/fast/text/systemFont-expected.png: Added.

You need to set svnprop.
Comment 5 Dean Jackson 2013-05-07 15:05:42 PDT
Comment on attachment 200973 [details]
Patch

r+ with changes required by svn and ChangeLog
Comment 6 Enrica Casucci 2013-05-07 15:41:09 PDT
Committed revision 149698.