Bug 11575

Summary:

REGRESSION: WebCore crash in CSSParser/HTMLTokenizer

Product:

WebKit

Reporter:

Matt Lilek <dev+webkit>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, mitz, rwlbuis

Priority:

Keywords:

NeedsReduction, Regression

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

URL:

http://www.nature.com/news/2006/061106/full/061106-17.html

Attachments:

Description	Flags
crash log	none
Crash fix	darin: review+
Test case	none

Matt Lilek

Reported 2006-11-11 20:39:39 PST

Loading URL causes crash on r17739. The window title updates properly, but after that it beachballs then crashes.

Attachments
crash log (21.62 KB, text/plain) 2006-11-11 20:40 PST, Matt Lilek	no flags	Details
Crash fix (1.35 KB, patch) 2006-11-12 10:44 PST, Rob Buis	darin: review+	Details Formatted Diff Diff
Test case (2.36 KB, application/octet-stream) 2006-11-14 09:28 PST, mitz	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Matt Lilek

Comment 1 2006-11-11 20:40:32 PST

Created attachment 11488 [details] crash log

Matt Lilek

Comment 2 2006-11-11 20:55:34 PST

Regressed between r17722 and r17739 (probably r17730).

David Kilzer (:ddkilzer)

Comment 3 2006-11-11 20:57:43 PST

Probably related to Bug 10893. Do nightlies before r17730 work without crashing?

Rob Buis

Comment 4 2006-11-12 10:44:37 PST

Created attachment 11500 [details] Crash fix I assumed the check was not needed, seeing that all tests passed, but it seems I was wrong. This patch does check for null and now the page works fine. Cheers, Rob.

mitz

Comment 5 2006-11-12 11:12:12 PST

Comment on attachment 11500 [details] Crash fix This needs a layout test.

Darin Adler

Comment 6 2006-11-13 10:55:11 PST

Comment on attachment 11500 [details] Crash fix Is there a way we can make a layout test for this? I'd prefer to have a regression test so that we don't make this mistake again in the future. r=me on the change, but I'd really like to see a test Also, no need to check in the line: + WARNING: NO TEST CASES ADDED OR CHANGED That's to help you when composing your change log.

mitz

Comment 7 2006-11-14 09:28:30 PST

Created attachment 11519 [details] Test case

Alexey Proskuryakov

Comment 8 2006-11-14 11:06:24 PST

Committed revision 17761 (with test).

Note You need to log in before you can comment on or make changes to this bug.